Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@JvmExposeBoxed annotation for opening API of inline classes to Java #331

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

CommanderTvis
Copy link
Member

No description provided.

Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document requires a lot more work to turn it into a finished design. We'll work offline on the list of required changes.

@CommanderTvis CommanderTvis force-pushed the commandertvis/jvmexpose branch from f29d7bf to 414ca21 Compare November 23, 2022 14:47
@CommanderTvis CommanderTvis changed the title Add @JvmExpose KEEP @JvmExposeBoxed annotation for opening API of inline classes to Java Dec 12, 2022
@CommanderTvis CommanderTvis force-pushed the commandertvis/jvmexpose branch from 311a75e to 9e87e46 Compare February 15, 2023 20:03
@k163377
Copy link

k163377 commented Oct 5, 2023

I did not see an issue, so let me comment directly.

How about allowing this annotation to be given to a single constructor or function as well?

I think there are only a limited number of situations where value class would be a problem.
Therefore, I feel that assigning value class on a per-class basis unnecessarily undermines the value of value class.

In addition, value class may not be defined or modified by the user.
Examples are unsigned integers and kotlin.time.Duration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants